fix(policy): update HuggingFace preset to router.huggingface.co#1481
fix(policy): update HuggingFace preset to router.huggingface.co#1481dknos wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 36 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughReplaced the HuggingFace preset network policy host from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
nemoclaw-blueprint/policies/presets/huggingface.yaml (1)
27-27: Add a hostname-specific regression test for this preset.Current tests only verify presets have endpoints, not that HuggingFace uses the expected inference host. Please add an assertion that
huggingfacepreset endpoints includerouter.huggingface.co(and optionally exclude the deprecated host) to prevent silent regressions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nemoclaw-blueprint/policies/presets/huggingface.yaml` at line 27, Add a focused regression test that checks the "huggingface" preset's endpoints include the hostname "router.huggingface.co" (and optionally assert it does not include the deprecated "api-inference.huggingface.co"). Implement this as a new unit test (e.g., TestHuggingFacePresetHost or add to TestPresetsEndpoints) that loads the presets map or uses the existing helper (e.g., presets["huggingface"] or GetPreset("huggingface")) and asserts the endpoints list contains "router.huggingface.co" and does not contain the deprecated host.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@nemoclaw-blueprint/policies/presets/huggingface.yaml`:
- Line 27: Add a focused regression test that checks the "huggingface" preset's
endpoints include the hostname "router.huggingface.co" (and optionally assert it
does not include the deprecated "api-inference.huggingface.co"). Implement this
as a new unit test (e.g., TestHuggingFacePresetHost or add to
TestPresetsEndpoints) that loads the presets map or uses the existing helper
(e.g., presets["huggingface"] or GetPreset("huggingface")) and asserts the
endpoints list contains "router.huggingface.co" and does not contain the
deprecated host.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d1527bbb-960b-4b26-a0e4-1c0767e86471
📒 Files selected for processing (1)
nemoclaw-blueprint/policies/presets/huggingface.yaml
|
✨ Thanks for submitting this fix, which proposes a way to update the HuggingFace policy preset from the deprecated Possibly related open issues: |
1 similar comment
|
✨ Thanks for submitting this fix, which proposes a way to update the HuggingFace policy preset from the deprecated Possibly related open issues: |
8b73c4a to
870ad63
Compare
The api-inference.huggingface.co endpoint returns HTTP 410 (Gone). Updated to the current router.huggingface.co endpoint. Fixes NVIDIA#1453 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
870ad63 to
9b165c2
Compare
Summary
api-inference.huggingface.coendpoint torouter.huggingface.coTest plan
router.huggingface.coFixes #1453
🤖 Generated with Claude Code
Summary by CodeRabbit